adding rundep bc. on budgie nheko would display blank
screen unless qt5-graphicaleffects was manually installed
resolves T10614
Details
Details
- Reviewers
TClark77 ReillyBrogan - Group Reviewers
Triage Team - Maniphest Tasks
- T10614: qt5-graphicaleffects rundep is missing for nheko
join solus channels; say hello;
Diff Detail
Diff Detail
- Repository
- R5651 nheko
- Branch
- master
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 5375 Build 5375: arc lint + arc unit
Event Timeline
Comment Actions
Thanks for contributing this patch. Please update the task summary and the commit message to be more in line with our standards
https://github.com/solus-project/tooling-central/blob/master/README.rst#using-git
- The task name should be "Update nheko to add runtime dependency"
- Update the commit message to explain exactly what's being done and the reasoning (per the link above)
- Add "resolves T10614" to the commit message.
The patch itself looks good.
Comment Actions
Thanks for updating the task name and adding the link. My apologies, I missed one other thing.
The summary of the commit should be the same as the summary of this task
Please amend your commit with this. I'll let Reilly approve the commit since he's the maintainer.
Comment Actions
Hi Nazar! My apologies but I saw the initial bug report but not that there was an open diff for it. I committed the fix and only then noticed this.