Details

Reviewers

EbonJaeger

Group Reviewers

Triage Team

Commits

R666:3373083da662: drumstick: Update to 2.8.0

Summary

Changelog available here
Depends on D14279.

Test Plan

Build VMPK
Check VMPK works

Diff Detail

Repository

R666 drumstick

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

stalebrim created this revision.Jul 24 2023, 12:00 AM

Herald added a reviewer: Triage Team. · View Herald TranscriptJul 24 2023, 12:00 AM

stalebrim requested review of this revision.Jul 24 2023, 12:00 AM

Harbormaster completed remote builds in B5319: Diff 34809.Jul 24 2023, 12:00 AM

stalebrim added a child revision: D14281: vmpk: Update to 0.8.9.Jul 24 2023, 12:03 AM

EbonJaeger requested changes to this revision.Jul 27 2023, 9:37 PM

EbonJaeger added a subscriber: EbonJaeger.

EbonJaeger added inline comments.

package.yml
13	The dependency is added, but the package isn't being built with DBus support. Is that intentional?

This revision now requires changes to proceed.Jul 27 2023, 9:37 PM

Enable dbus and apply a patch for build

Harbormaster completed remote builds in B5382: Diff 34908.Aug 7 2023, 4:01 PM

EbonJaeger requested changes to this revision.Aug 7 2023, 6:13 PM

EbonJaeger added inline comments.

package.yml
24–25	We're trying to move to `%patch -p1 -i $pkgfiles/name-of-file.patch` for patching files. If you could do that here, that'd be great. :)

This revision now requires changes to proceed.Aug 7 2023, 6:13 PM

Add homepage

Harbormaster completed remote builds in B5386: Diff 34912.Aug 8 2023, 9:35 AM

Make the actual change that was requested

Harbormaster completed remote builds in B5387: Diff 34913.Aug 8 2023, 9:36 AM

stalebrim retitled this revision from Update drumstick to 2.8.0 to drumstick: Update to 2.8.0.Aug 8 2023, 11:38 AM

LGTM, thanks! :)

This revision is now accepted and ready to land.Aug 8 2023, 2:10 PM

Closed by commit R666:3373083da662: drumstick: Update to 2.8.0 (authored by stalebrim, committed by EbonJaeger). · Explain WhyAug 8 2023, 2:11 PM

This revision was automatically updated to reflect the committed changes.

EbonJaeger added a commit: R666:3373083da662: drumstick: Update to 2.8.0.

drumstick: Update to 2.8.0
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 34915

abi_symbols

abi_used_libs

abi_used_symbols

files/0001-Fixed-GH-ticket-13-build-errors-in-drumstick-2.8.0.patch

package.yml

pspec_x86_64.xml

drumstick: Update to 2.8.0ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 34915

abi_symbols

abi_used_libs

abi_used_symbols

files/0001-Fixed-GH-ticket-13-build-errors-in-drumstick-2.8.0.patch

package.yml

pspec_x86_64.xml

drumstick: Update to 2.8.0
ClosedPublic
Actions

Revision Contents
Changeset List