Page MenuHomeSolus

Update protonmail-bridge to v3.3.2
ClosedPublic

Authored by FriesischScott on Jul 27 2023, 7:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Aug 31, 12:42 AM
Unknown Object (File)
Thu, Aug 29, 10:43 PM
Unknown Object (File)
Thu, Aug 29, 10:07 AM
Unknown Object (File)
Tue, Aug 27, 9:41 AM
Unknown Object (File)
Tue, Aug 27, 9:41 AM
Unknown Object (File)
Tue, Aug 27, 8:43 AM
Unknown Object (File)
Mon, Aug 26, 12:06 PM
Unknown Object (File)
Fri, Aug 16, 12:29 AM

Details

Summary

The build system changed a lot compared to the last update I did and I had to patch a number of things to make it work. Since the last release one of the binaries was split into bridge and bridge-gui which I included as proton-bridge and proton-bridge-gui. The launcher application remains as protonmail-bridge.

The new build uses vcpkg and I included port overlays for the dependencies to fall back on the system libaries. Because vcpkg is expected as a submodule I had to switch the build to the git tag.

Summarized changelog:

  • 3.3.0
    • Added new notifications to help users to configure and troubleshoot their email clients
  • 3.2.0
    • Enhanced the integration with the operating system by replacing status windows with native tray icon context menu
  • 3.1.2
    • Support for Protons Scheduled send feature
    • Synchronization indicator in the GUI
  • 3.0.20
    • Fixed a bug that could cause email states to come out of sync with the web application
  • 3.0.17
    • Significant rewrite of bridge and update to Qt6
    • Improved sending and synchronization performance
    • Added subfolder support

Full changelog: https://proton.me/download/bridge/stable_releases.html

Test Plan

Synced and sent mail through Thunderbird.

Diff Detail

Repository
R5138 protonmail-bridge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fix version in git commit headline

FriesischScott retitled this revision from Update protonmail-bridge to v3.2.2 to Update protonmail-bridge to v3.3.2.Jul 27 2023, 7:37 PM

Clean unused patches from package.yml

So generally we're still preferring to build apps with qt5 if possible if a particular app supports both qt5 and qt6. The reason for this is that qt5 apps tend to look better and more integrated on Plasma due to Plasma's Breeze theme not yet being ported to qt6. If this package only supports qt6 now that's fine, it may also apply it's own custom theme at which point it doesn't matter.

So generally we're still preferring to build apps with qt5 if possible if a particular app supports both qt5 and qt6. The reason for this is that qt5 apps tend to look better and more integrated on Plasma due to Plasma's Breeze theme not yet being ported to qt6. If this package only supports qt6 now that's fine, it may also apply it's own custom theme at which point it doesn't matter.

They only support qt6. But they don't use the system theme anyway.

cmake, ninja-build and Qt 6 are required to build the graphical user interface.

EbonJaeger added a subscriber: EbonJaeger.

Just a couple things that I noticed.

package.yml
22

This should go above the icu-uc dependency because of alphabetical ordering.

27

We're trying to move to %patch -p1 -i $pkgfiles/name-of-file.patch for patching files. If you could do that here, that'd be great. :)

This revision now requires changes to proceed.Aug 7 2023, 2:40 PM
EbonJaeger edited the summary of this revision. (Show Details)

LGTM, thanks! :)

This revision is now accepted and ready to land.Aug 8 2023, 2:26 PM
This revision was automatically updated to reflect the committed changes.